Changeset 2435

Show
Ignore:
Timestamp:
10/19/08 02:51:00 (3 months ago)
Author:
bzr
Message:
  • NVDAObjects.IAccessible.Dialog.getDialogText: Don't descend into property pages to gather dialog text, as property pages will call getDialogText() themselves to gather their own text. Fixes the issue where the dialog's description might contain the text of child property pages.
  • NVDAObjects.IAccessible.Dialog: Minor cosmetic fixes.
Location:
trunk
Files:
3 modified

Legend:

Unmodified
Added
Removed

  • trunk

    • Property bzr:revision-info

      •  

        old new  
        1 timestamp: 2008-10-17 16:22:42.651999950 +1000 
         1timestamp: 2008-10-19 12:46:33.749000072 +1000 
        22committer: James Teh <jamie@jantrid.net> 
        33properties:  
    • Property bzr:revision-id:v3-list-QlpoOTFBWSZTWbrL2vUAAB1VgAAQABCAQDrrnqAgAFCgaaGRkxBoTIJ6mmaNRwhndFAoNhZjh_YY4a01fOg1ulgNNC2UrzPdXXEnDpX8XckU4UJC6y9r1A..

      •  

        old new  
        2042042232 peterb.v@datagate.sk-20081016202124-82z07ddvi5lla90z 
        2052052233 jamie@jantrid.net-20081017062242-58oc9d002nihw3hu 
         2062234 jamie@jantrid.net-20081019024633-rahtbtmbuenafjfz 
    • Property bzr:file-ids

      •  

        old new  
        11source/NVDAObjects/IAccessible/__init__.py      683@dbe06fc7-9119-0410-a01d-9dbf589ecbba:trunk:source%2FNVDAObjects%2FIAccessible%2F__init__.py 
        2 source/NVDAObjects/__init__.py  683@dbe06fc7-9119-0410-a01d-9dbf589ecbba:trunk:source%2FNVDAObjects%2F__init__.py 
         2user_docs/whats%20new.txt       559@dbe06fc7-9119-0410-a01d-9dbf589ecbba:trunk:user_docs%2Fwhats%20new.txt 

  • trunk/source/NVDAObjects/IAccessible/__init__.py

    r2434 r2435  
    870870 
    871871class Dialog(IAccessible): 
    872         """ 
    873         Based on NVDAObject but on foreground events, the dialog contents gets read. 
     872        """Overrides the description property to obtain dialog text. 
    874873        """ 
    875874 
    … …  
    886885                        childStates=children[index].states 
    887886                        childRole=children[index].role 
    888                 #We don't want to handle invisible or unavailable objects 
     887                        #We don't want to handle invisible or unavailable objects 
    889888                        if controlTypes.STATE_INVISIBLE in childStates or controlTypes.STATE_UNAVAILABLE in childStates:  
    890889                                continue 
    891                 #For particular objects, we want to decend in to them and get their childrens' message text 
    892                         if childRole in (controlTypes.ROLE_PROPERTYPAGE,controlTypes.ROLE_PANE,controlTypes.ROLE_PANEL,controlTypes.ROLE_WINDOW): 
     890                        #For particular objects, we want to decend in to them and get their childrens' message text 
     891                        if childRole in (controlTypes.ROLE_PANE,controlTypes.ROLE_PANEL,controlTypes.ROLE_WINDOW): 
    893892                                textList.append(cls.getDialogText(children[index])) 
    894893                                continue 
    … …  
    898897                                if index>0 and children[index-1].role==controlTypes.ROLE_GROUPING: 
    899898                                        continue 
    900                         #Like the last one, but a graphic might be before the grouping's description 
     899                                #Like the last one, but a graphic might be before the grouping's description 
    901900                                if index>1 and children[index-1].role==controlTypes.ROLE_GRAPHIC and children[index-2].role==controlTypes.ROLE_GROUPING: 
    902901                                        continue 

  • trunk/user_docs/whats new.txt

    r2432 r2435  
    3838* new: Key names announced by keyboard help are now translatable. 
    3939* new: Added support for the recognized text field in SiRecognizer. (#198) 
     40* fix: When entering both a dialog and a property page inside that dialog, the text of the property page is no longer spoken twice. 
    4041 
    4142